Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to connect to secure grpc port #35

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Mar 5, 2024

this patch add TlsOption that allows user to connect to a tls protected grpc port.

This option can be configured via GreptimeOption builder. It also contains optional certficate and trust root when the server hosts self-signed certificate.

@sunng87 sunng87 marked this pull request as ready for review March 9, 2024 02:13
@sunng87 sunng87 requested a review from fengjiachun March 9, 2024 02:14
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit 7338cd5 into main Mar 11, 2024
4 checks passed
@fengjiachun fengjiachun deleted the feature/tls-options branch March 11, 2024 02:57
@sunng87
Copy link
Member Author

sunng87 commented Mar 11, 2024

Thank you @fengjiachun . Could you make a release for this feature?

@fengjiachun
Copy link
Contributor

Thank you @fengjiachun . Could you make a release for this feature?

v0.7.3 has already been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants